Review Request: Fix for connecting to FTP sites through HTTP proxy
adawit at kde.org
Wed Mar 9 19:06:40 GMT 2011
On Wed, Mar 9, 2011 at 12:46 PM, David Faure <faure at kde.org> wrote:
> On Wednesday 09 March 2011, Dawit Alemayehu wrote:
>> proxiedBy always returns true since ftp.protocol no longer contains a
>> "ProxiedBy=" entry.
> Yes it does, of course. But the point of the additional if() is to not go into
> that code block for other procotols, like HTTP, FISH, and so on.
I meant to say "always returns false". KProtocolInfo::proxiedBy(...)
always returns an empty string for FTP. I just looked at the log for
ftp.protocol file and it seems that Andreas had mistakenly removed the
"proxiedBy=" statement from the ftp.protocol file. See
As such the changes the fix I committed current does not fix the
problem. FTP over HTTP proxy still does not work. Anyhow, if the
incorrect commit mentioned above gets reverted, the problem away. Any
objections with me doing that ?
More information about the kde-core-devel