Review Request: Add a GUI to configure window's title bar blend colours

Jonathan Marten jjm at keelhaul.me.uk
Tue Mar 8 17:23:57 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/
-----------------------------------------------------------

(Updated March 8, 2011, 5:23 p.m.)


Review request for KDE Base Apps and kwin.


Changes
-------

Use "Secondary" instead of "Blend" as suggested.

Also reorder the items so that the 3 "Active" settings come
together, followed by the 3 "Inactive" settings.

kwin group added to reviewers.


Summary
-------

Some of the still available window decorations (KDE2, Keramik, Modern System, Quartz,
Redmond) use two colours for the title bar, either as a blend or for different
parts of the bar.  This patch extends the GUI in System Settings to allow the
blend colour to be configured.


This addresses bug 225837.
    http://bugs.kde.org/show_bug.cgi?id=225837


Diffs (updated)
-----

  kcontrol/colors/colorscm.h 7627db8 
  kcontrol/colors/colorscm.cpp 571ed86 
  kcontrol/colors/colorsettings.ui efd618b 

Diff: http://git.reviewboard.kde.org/r/100821/diff


Testing
-------

Built kde-workspace with these changes, verified operation of systemsettings and KDE2 window decoration.


Screenshots
-----------

kcontrol screenshot
  http://git.reviewboard.kde.org/r/100821/s/93/


Thanks,

Jonathan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110308/08cf79bb/attachment.htm>


More information about the kde-core-devel mailing list