Review Request: Fix global shortcuts that needs shift key, like for example ctrl+% (ctrl+shift+5 on many keyboards)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101520/#review4244
-----------------------------------------------------------


This review has been submitted with commit 568cb9268a3f940564d155526cb81cec4327cbf6 by Simon Persson to branch master.

- Commit


On June 6, 2011, 11:02 a.m., Simon Persson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101520/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 11:02 a.m.)
> 
> 
> Review request for KDE Runtime and Michael Jansen.
> 
> 
> Summary
> -------
> 
> Second patch to fix this bug, depends on patch in review request 101515.
> 
> KKeySequenceWidget used to enter shortcuts removes shift from the recorded shortcut if the symbol produced from that physical key is different when shift is used (upper/lowercase letters doesn't count). kglobalaccel needs to include shift in the grab in order to be triggered on this class of shortcuts, and then in the keypress event handler it also needs to strip the shift again before checking which shortcut was just triggered.
> 
> 
> This addresses bugs 179504, 197548 and 215030.
>     http://bugs.kde.org/show_bug.cgi?id=179504
>     http://bugs.kde.org/show_bug.cgi?id=197548
>     http://bugs.kde.org/show_bug.cgi?id=215030
> 
> 
> Diffs
> -----
> 
>   kglobalaccel/kglobalaccel_x11.cpp 2576d2e 
> 
> Diff: http://git.reviewboard.kde.org/r/101520/diff
> 
> 
> Testing
> -------
> 
> Tested using the master branch, running in a Xephyr session using gb,us and se keyboard layouts. The tested layout needs to be the first entry in the list of layouts  in the keyboard layout switcher, otherwise it will not work. Works for all the !"£$%^&*()_+ etc, no regression on shortcuts with only a number, only a letter or shift+letter. Also no regression on alt+shift+tab or ctrl+shift+esc.
> 
> 
> Thanks,
> 
> Simon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110629/7cdaabfc/attachment.htm>