Creating a public pixmap overlays method based on icon overlays?

David Faure faure at
Mon Jun 6 19:04:38 BST 2011

On Thursday 02 June 2011, Matthias Fuchs wrote:
> Hi,
> I was looking at BUG:190579 [1] and realised that there is a general
> problem in KDE that does not only apply to folders:
> As soon as you have preview enabled you won't get any more icon overlays
> for images, no matter if you look at images directly or at folders
> containing images (the later most likely because the previews are pointed
> over the overlay).
> So I thought what should be done is to also display overlays for previews.
> Yet the overlay method only applies to icons at the moment. [2]
> The code that is used [3] can be easily adpated to pixmaps not having the
> same width and height. [4]
> I even tried it and it looks good enough in my opinion.
> Now I need your feedback:
> Should a more general method like that be added?
> Should that method be used for previews and also KIconLoader?
> And where should such a method be placed, I mean in which header?

Well, it sound like it should be a KIconLoader method since it actually needs 
KIconLoader to load the overlay icons (line 393). So basically this would just 
mean making drawOverlays public, AFAICS.

David Faure, faure at,
Sponsored by Nokia to work on KDE, incl. Konqueror (

More information about the kde-core-devel mailing list