Review Request: kcm-grub2

[Konstantinos Smanis]

Raphael Kubo da Costa <kubito <at> gmail.com> writes:

> Konstantinos Smanis <konstantinos.smanis <at> gmail.com> writes:
>
> > On Thu, May 26, 2011 at 00:03, Konstantinos Smanis
> > <konstantinos.smanis <at> gmail.com> wrote:
> >>> The following line should probably be simplified (see
> >>> http://websvn.kde.org/?revision=1184860&view=revision):
> >>>
> >>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new
> >>> QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name
> >>> << partition->filePath() << volume->label() << volume->fsType() <<
> >>> i18n("%1 GiB", QString::number(volume->size() / 1073741824)));
> >>
> >> Thanks. Fixed: http://commits.kde.org/kcm-grub2/87eac2b1ef0b8f3a1907b86ab7054b99a0ed5ab9
> >>
> >> Konstantinos
> >
> > If noone else objects, would it be possible for a sysadmin to make the move?
>
> This is not really an objection, as I have not looked at the code. But
> having two different projects with practically identical names
> (kcm_grub2 and kcmgrub2) is quite confusing. It'd be nice if this could
> be worked out, as both projects have actually asked for review and to be
> moved to the same final destination (extragear/sysadmin).

I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he
has agreed to give up his request for inclusion in extragear.

Our conversation has been over plain e-mails, so I cannot prove this.
Perhaps I should contact him to confirm this?

Konstantinos