Review Request: kcm-grub2

Raphael Kubo da Costa kubito at
Fri Jun 3 00:16:28 BST 2011

Konstantinos Smanis <konstantinos.smanis at> writes:

> On Thu, May 26, 2011 at 00:03, Konstantinos Smanis
> <konstantinos.smanis at> wrote:
>>> The following line should probably be simplified (see
>>> src/kcm_grub2.cpp:113:                    QTreeWidgetItem *item = new
>>> QTreeWidgetItem(ui.treeWidget_recover, QStringList(QString()) << name
>>> << partition->filePath() << volume->label() << volume->fsType() <<
>>> i18n("%1 GiB", QString::number(volume->size() / 1073741824)));
>> Thanks. Fixed:
>> Konstantinos
> If noone else objects, would it be possible for a sysadmin to make the move?

This is not really an objection, as I have not looked at the code. But
having two different projects with practically identical names
(kcm_grub2 and kcmgrub2) is quite confusing. It'd be nice if this could
be worked out, as both projects have actually asked for review and to be
moved to the same final destination (extragear/sysadmin).

More information about the kde-core-devel mailing list