Review Request: Fix auth warnings when authentication is legitimate

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101493/#review3628
-----------------------------------------------------------

Ship it!


Good catch.

- Dawit


On June 2, 2011, 12:03 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101493/
> -----------------------------------------------------------
> 
> (Updated June 2, 2011, 12:03 p.m.)
> 
> 
> Review request for kdelibs and Dawit Alemayehu.
> 
> 
> Summary
> -------
> 
> Commit 3bbd4496bc introduced spurious warnings when auth info was added to HTTP request and authentication succeeded as the response code will never be 401 or 407 in that case.
> 
> This patch takes into account the previous response code when deciding if a warning should be issued.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp b4d3c65 
> 
> Diff: http://git.reviewboard.kde.org/r/101493/diff
> 
> 
> Testing
> -------
> 
> Tested that the expected behaviour is still wanted, and that successful authentication attempts did not result in warnings.
> 
> 
> Thanks,
> 
> Grégory
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110602/a4c56fa6/attachment.htm>