Review Request: Fix auth warnings when authentication is legitimate

Grégory Oestreicher greg at
Thu Jun 2 13:03:58 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Dawit Alemayehu.


Commit 3bbd4496bc introduced spurious warnings when auth info was added to HTTP request and authentication succeeded as the response code will never be 401 or 407 in that case.

This patch takes into account the previous response code when deciding if a warning should be issued.


  kioslave/http/http.cpp b4d3c65 



Tested that the expected behaviour is still wanted, and that successful authentication attempts did not result in warnings.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list