QComboBox vs KConfigDialogManager

[Jeremy Whiting]

On Tue, May 31, 2011 at 11:13 PM, Aaron J. Seigo <aseigo at kde.org> wrote:

> On Tuesday, May 31, 2011 21:55:59 Jeremy Whiting wrote:
> > 1) Check if the widget has a kcfg_property is set on the widget.  If so,
> use
> > that property's value as the property to record.
> > 2) Check if the widget has a User property to save (This was not set in
> > QComboBox in 4.7 but is set in 4.8 to the currentIndex property)
> > 3) Try casting to a combobox and use the current text if the combobox is
> > editable, otherwise use the currentIndex
> >
> > Anyone here can guess where the problem lies?
>
> erf!
>
> > a) change all our .ui files KComboBox, QComboBox widgets to have
> > kcfg_property set if we want to save the currentText as the value of the
> > config item.
>
> this doesn't sound like a great solution since it means not only a lot of
> work
> and testing in our own repos (with a high risk of missing something), but
> it
> will affect all third parties as well (which we can't guarantee will notice
> or
> provide a fix on their own).


Indeed, I posted that more as an absurd solution than one I would recommend.


> a fix, even if it is a (well documented with
> comments ;) work-around, in KConfigDialogManager would probably be more
> valuable as a result.
>

I just uploaded a diff to reviewboard that fixes the problem here.  Let me
know if it's ok to ship.

Jeremy


>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110601/1b283f28/attachment.htm>