Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

Kai Uwe Broulik kde at
Sat Jul 30 15:51:52 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated July 30, 2011, 2:51 p.m.)

Review request for kdelibs.


Sorry for the noise again. Forgot a screenshot :)


This patch improves the Calculate and Stop buttons in folder properties.
Instead of having two buttons that are enabled/disabled accordingly, we only have one that toggles (technically there are still two buttons but it looks as if there was one)

I removed that "Calculating..." label when there is already a size shown, instead the stop button says "Stop Calculating" and somehow serves as "indicator".
Also, I added a line-break after the "Calculating..." so the label doesn't change its size making the other elements moving around.

I don't know if the additional icons (view-refresh and process-cancel) add too much clutter to the visual interface since this features is not sooo important/frequently used(?) that the buttons need an icon.


  kio/kfile/kpropertiesdialog.cpp ba56f18 



Compiles and the buttons toggle (and react) fine.


Screenshot of the dialog while it is calculating


Kai Uwe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list