Review Request: Makeobj variable substitution in $OBJ_SUBDIR and $OBJ_REPLACEMENT

David Faure faure at kde.org
Tue Jan 18 21:42:17 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6354/#review9656
-----------------------------------------------------------

Ship it!


Good stuff.

At some point we should extract the "switch to build dir" code into a separate file, so that it can be used by the "cb" alias/script, too...

- David


On Jan. 17, 2011, 10:01 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6354/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2011, 10:01 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adds variable substitution to makeobj's $OBJ_SUBDIR and $OBJ_REPLACEMENT, allowing one to maintain multiple builddirs within the same project directory. This is especially useful for keeping builddirs for different branches in 1 git repo.
> 
> For example, one could set OBJ_SUBDIR=build-%GITBRANCH% and then have build-branch1; build-branch2... within the same git repo.
> 
> Also, I added variables for keeping builddirs of different platforms inside the same project dir.
> So you could have have build-master-gcc; build-master-icc; build-branch-gcc; build-branch-icc all in the same project.
> 
> We could always add more variables as needed, but for now I only have these:
>  %BRANCH% with the name of the Git or SVN branch you are in (as applicable)
>  %GITBRANCH% with the name of the Git branch you are in (empty if not in a Git branch)
>  %SVNBRANCH% with the name of the SVN branch you are in (empty if not in an SVN branch)
>  %CC% with the basename of your C compiler set in $CC (gcc if empty)
>  %CXX% with the basename of your C++ compiler set in $CXX (g++ if empty)
>  %ARCH% with the machine architecture (i.e. 'uname -m')
>  %OS% with the operating system name (i.e. 'uname -o'), in lower-case without "GNU"
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdesdk/scripts/makeobj 1208110 
> 
> Diff: http://svn.reviewboard.kde.org/r/6354/diff
> 
> 
> Testing
> -------
> 
> building kdepim-master and kdepim-enterprise and kdepim-4.4 all in the same git repo.
> 
> 
> Thanks,
> 
> Allen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110118/bfd2a407/attachment.htm>


More information about the kde-core-devel mailing list