Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6183/
-----------------------------------------------------------

(Updated 2011-01-05 06:21:31.733660)


Review request for kdelibs and Andrea Diamantini.


Changes
-------

This is the final version of the patch that will be commited. The only change made is the removal of the KIO::Scheduler::publishSlaveOnHold call from the new putReplyOnHold function and the addition of the same call at a location (KWebPage::downloadRequest) where we are about to hand the request over to another application. Patch is going in tomorrow...


Summary
-------

The attached patch fixes a long standing issue in the KIO-QNAM class where actions that require putting an ioslave on hold currently do not work. In kdewebkit, which uses this integration class, such actions always occur when you click on a link that cannot be directly handled by the browsing engine. For example, clicking on a link that points to a PDF link. Even worse is when the link you click on results in an http POST which returns content. In such cases, apps that rely on kdewebkit and hence the KIO-QNAM bridge class have no way of putting an ioslave on hold as stated in KIO::get's documentation in order to properly deal with content types they do not support.

The attached patch along with another pending against kio_http, http://reviewboard.kde.org/r/6182/ , remedies this issue by adding a means to put replies on hold and fixing the downloadResponse slot in KWebPage to do the right thing.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdewebkit/ISSUES 1211858 
  trunk/KDE/kdelibs/kdewebkit/ISSUES 1211858 
  trunk/KDE/kdelibs/kdewebkit/kwebpage.h 1211858 
  trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp 1211858 
  trunk/KDE/kdelibs/kio/kio/accessmanager.h 1211858 
  trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1211858 
  trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h 1211858 
  trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1211858 

Diff: http://svn.reviewboard.kde.org/r/6183/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110105/49ef3ffa/attachment.htm>