<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6183/">http://svn.reviewboard.kde.org/r/6183/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Andrea Diamantini.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated 2011-01-05 06:21:31.733660</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the final version of the patch that will be commited. The only change made is the removal of the KIO::Scheduler::publishSlaveOnHold call from the new putReplyOnHold function and the addition of the same call at a location (KWebPage::downloadRequest) where we are about to hand the request over to another application. Patch is going in tomorrow...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch fixes a long standing issue in the KIO-QNAM class where actions that require putting an ioslave on hold currently do not work. In kdewebkit, which uses this integration class, such actions always occur when you click on a link that cannot be directly handled by the browsing engine. For example, clicking on a link that points to a PDF link. Even worse is when the link you click on results in an http POST which returns content. In such cases, apps that rely on kdewebkit and hence the KIO-QNAM bridge class have no way of putting an ioslave on hold as stated in KIO::get's documentation in order to properly deal with content types they do not support.
The attached patch along with another pending against kio_http, http://reviewboard.kde.org/r/6182/ , remedies this issue by adding a means to put replies on hold and fixing the downloadResponse slot in KWebPage to do the right thing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdewebkit/ISSUES <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kdewebkit/ISSUES <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kdewebkit/kwebpage.h <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanager.h <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanager.cpp <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.h <span style="color: grey">(1211858)</span></li>
<li>trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp <span style="color: grey">(1211858)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6183/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>