KShutdown got to kde-runtime without review

Albert Astals Cid aacid at kde.org
Tue Feb 22 19:38:51 GMT 2011


A Dimarts, 22 de febrer de 2011, Ralf Habacker va escriure:
> Am 17.02.2011 20:58, schrieb Albert Astals Cid:
> > A Dijous, 17 de febrer de 2011, Ralf Habacker va escriure:
> >> Am 16.02.2011 20:40, schrieb Albert Astals Cid:
> >>> Why?
> >> 
> >> I'm currently the only reviewer for windows and I reviewed the code
> >> already :-)
> > 
> > You failed to find out you are not correctly loading the translation
> > catalog.
> 
> Your are refering to the second parameter of the KAboutData construction
> ? 

Yes.

> I copied it from kwinstartmenu where this parameter has been set to
> "kdebase-runtime" in 2009 as has been adapted to the new package name.

Was wrong there too.

> I will set both to zero.
> 
> Thanks for this pointer, which fixes a long outstanding bug too.

You're welcome.

Albert

> 
> Ralf




More information about the kde-core-devel mailing list