Review Request: Allow to configure thumbnail-plugins

Peter Penz peter.penz19 at gmail.com
Tue Feb 22 16:26:36 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100717/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Summary
-------

The patch allows to make thumbnail-plugins configurable by the user. One example is the JPEG-thumbnail-plugin: Some users prefer that the preview gets rotated automatically corresponding to the EXIF-information, for some users the automatic-rotating is an issue (e.g. they want to see in Dolphin/Konqueror whether the image needs to get rotated manually).

In KDE SC 4.6 we tried to bypass this issue by offering 2 plugins: One JPEG-thumbnail-plugin for unrotated JPEGs and one for automatically-rotated JPEGS. But this is just a hack as when enabling both plugins it is undetermined which plugin will be used...


Diffs
-----

  kio/kio/thumbcreator.h 51234e7 
  kio/kio/thumbcreator.cpp 4384814 

Diff: http://git.reviewboard.kde.org/r/100717/diff


Testing
-------

The patch has been tested by implementing a configuration option for the JPEG-thumbnail-plugin (see screenshot).


Screenshots
-----------

Configure JPEG-thumbnail-plugin
  http://git.reviewboard.kde.org/r/100717/s/82/


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110222/e9dbfaca/attachment.htm>


More information about the kde-core-devel mailing list