<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100717/">http://git.reviewboard.kde.org/r/100717/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Peter Penz.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch allows to make thumbnail-plugins configurable by the user. One example is the JPEG-thumbnail-plugin: Some users prefer that the preview gets rotated automatically corresponding to the EXIF-information, for some users the automatic-rotating is an issue (e.g. they want to see in Dolphin/Konqueror whether the image needs to get rotated manually).
In KDE SC 4.6 we tried to bypass this issue by offering 2 plugins: One JPEG-thumbnail-plugin for unrotated JPEGs and one for automatically-rotated JPEGS. But this is just a hack as when enabling both plugins it is undetermined which plugin will be used...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch has been tested by implementing a configuration option for the JPEG-thumbnail-plugin (see screenshot).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/thumbcreator.h <span style="color: grey">(51234e7)</span></li>
<li>kio/kio/thumbcreator.cpp <span style="color: grey">(4384814)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100717/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100717/s/82/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/22/configurable-thumbnails_400x100.png" style="border: 1px black solid;" alt="Configure JPEG-thumbnail-plugin" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>