Review Request: Patch to build only kmime + kimap

[Gregory Schlomoff]

> On Feb. 21, 2011, 10:02 a.m., Christophe Giboudeaux wrote:
> > CMakeLists.txt, line 17
> > <http://git.reviewboard.kde.org/r/100698/diff/1/?file=9724#file9724line17>
> >
> >     Why do you need to explicitely set this if your target is Windows and Mac ?
> >

Because otherwise I get the following CMake error:

_______________________
D:\kde\build\kdepimlibs>cmake -G "NMake Makefiles" -DCMAKE_INSTALL_PREFIX="D:/kde" -DCMAKE_PREFIX_PATH="D:/kde" -DCMAKE_BUILD_TYPE=Debug -DSTATIC_LIBRARY=ON -DKDE4_BUILD_TESTS=OFF -DKIMAP_STANDALONE=ON -DCMAKE_CXX_FLAGS="-DKIMAP_STANDALONE -DKDEWIN_STATIC_LIBS" -DKDEPIM_NO_KRESOURCES=ON -DKDEPIM_NO_KCAL=ON -DCMAKE_CXX_FLAGS="-DKDELIBS_STATIC_LIBS" "D:/kde/src/kdepimlibs"

CMake Error at C:/Program Files (x86)/CMake 2.8/share/cmake-2.8/Modules/FindKDE4.cmake:98 (MESSAGE):
  ERROR: cmake/modules/FindKDE4Internal.cmake not found in
  c:/users/greg/appdata/roaming/.kde-debug/share/apps;d:/kde/build/kdepimlibs/share/apps
Call Stack (most recent call first):
  CMakeLists.txt:23 (find_package)

[...]

-- Configuring incomplete, errors occurred!

D:\kde\build\kdepimlibs>
________________________

Basically, without this, CMake searches for FindKDE4Internal.cmake in the build folder (d:/kde/build/kdepimlibs/share/apps) instead of the kde install folder (d:/kde/share/apps)


> On Feb. 21, 2011, 10:02 a.m., Christophe Giboudeaux wrote:
> > CMakeLists.txt, line 74
> > <http://git.reviewboard.kde.org/r/100698/diff/1/?file=9724#file9724line74>
> >
> >     indentation between your if/endif

Sorry, will update diff


- Gregory


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100698/#review1549
-----------------------------------------------------------


On Feb. 21, 2011, 8:42 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100698/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 8:42 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> Patches to kdepimlibs to build only kimap and kmime. Please see https://git.reviewboard.kde.org/r/100697/ for the discussion.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a486fc1 
> 
> Diff: http://git.reviewboard.kde.org/r/100698/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/