Review Request: Patch to build only kmime + kimap

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100698/#review1549
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1322>

    Why do you need to explicitely set this if your target is Windows and Mac ?
    



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1326>

    indentation between your if/endif



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1327>

    indentation between your if/endif



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1328>

    indentation



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1323>

    Please, don't duplicate add_subdirectory.
    
    Use something like:
    
    if(KIMAP_STANDALONE)
      set(build_kmime TRUE)
      set(build_kimap TRUE)
    endif()
    



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1324>

    add this to the KDEPIM_ONLY_KLEO line just below.
    
    



CMakeLists.txt
<http://git.reviewboard.kde.org/r/100698/#comment1325>

    then: endif(NOT KDEPIM_ONLY_KLEO AND NOT KIMAP_STANDALONE)
    


- Christophe


On Feb. 21, 2011, 8:42 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100698/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 8:42 a.m.)
> 
> 
> Review request for kdelibs and KDEPIM-Libraries.
> 
> 
> Summary
> -------
> 
> Patches to kdepimlibs to build only kimap and kmime. Please see https://git.reviewboard.kde.org/r/100697/ for the discussion.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a486fc1 
> 
> Diff: http://git.reviewboard.kde.org/r/100698/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/