Review Request: Implement a dialog to show unhandled Bugzilla errors

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100681/#review1550
-----------------------------------------------------------



drkonqi/reportassistantpages_bugzilla.cpp
<http://git.reviewboard.kde.org/r/100681/#comment1329>

    You have to check if the pointer is still valid there.
    
    The reason for using QPointer or QWeakPointer in the first place is that the dialog could be destroyed by e.g. a dbus command IIRC --> there was a blog entry on how to crash nearly every KDE app which commented on that.
    
    So it could be that it is not valid once it reaches the KUrl fileUrl = ... line.
    The only way to check if it is valid is using QWeakPointer or QPointer and do KUrl fileUrl (dlg ? dlg->selectedUrl() : KUrl());
    
    Yes I suppose in the worst case it could be deleted inbetween but that should not happen that often. ;)


- Matthias


On Feb. 19, 2011, 12:33 p.m., Darío Andrés Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100681/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 12:33 p.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Summary
> -------
> 
> Initial patch
> 
> I created a dialog that will show the RAW Bugzilla HTML output when the response can't be parsed by DrKonqi. The user is encouraged to perform the action again later or save the HTML data to submit a DrKonqi bug.
> 
> This function is available for the login and the submit (new report or attach to an existant one) processes.
> BugzillaLib error message signals were enhanced to hold the raw html (if it makes sense to show it)
> 
> The text on the dialog could be changed.
> 
> Additional fix: disconnect signals prior to creating a new report or attaching to an existing one; avoiding duplicates dialog. (may be this should go as another patch)
> 
> 
> This addresses bug 266542.
>     http://bugs.kde.org/show_bug.cgi?id=266542
> 
> 
> Diffs
> -----
> 
>   drkonqi/CMakeLists.txt 87c3d24 
>   drkonqi/bugzillalib.h cb7da10 
>   drkonqi/bugzillalib.cpp 348fb72 
>   drkonqi/reportassistantdialog.cpp 607dd63 
>   drkonqi/reportassistantpages_bugzilla.h 8681f22 
>   drkonqi/reportassistantpages_bugzilla.cpp e896c52 
>   drkonqi/reportinterface.h a1fc78a 
>   drkonqi/reportinterface.cpp a484d11 
> 
> Diff: http://git.reviewboard.kde.org/r/100681/diff
> 
> 
> Testing
> -------
> 
> Tested by faking some errors during the login and submit (new report) processes.
> The code should be reviewed as I stop coding for KDE several months ago.
> 
> 
> Screenshots
> -----------
> 
> Unhandled Error Dialog
>   http://git.reviewboard.kde.org/r/100681/s/77/
> 
> 
> Thanks,
> 
> Darío Andrés
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110221/8358c319/attachment.htm>