Review Request: Fix DAV jobs bug

[Dawit Alemayehu]

> On Feb. 20, 2011, 10:20 p.m., Dawit Alemayehu wrote:
> > kioslave/http/http.cpp, line 4059
> > <http://git.reviewboard.kde.org/r/100694/diff/3/?file=9647#file9647line4059>
> >
> >     The size variable here needs to be qint64.

Oh, just in case you are not already aware, please use "REVIEW:100684" in your commit message so this review can be found as needed from the git commit log. It will also automatically close this review request for you. Thanks.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100694/#review1538
-----------------------------------------------------------


On Feb. 20, 2011, 10:03 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100694/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 10:03 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Following commit 01db8ec6e9934a13ed8025949dab9dd43010bf53 the DAV jobs created with the DavJob::dav* utility functions ceased to work because they do not provide the body data length. This patch corrects this issue by using the same mechanisms as those used for HTTP POST requests.
> 
> 
> Diffs
> -----
> 
>   kio/kio/davjob.cpp 3b2a8da 
>   kioslave/http/http.h e8fe695 
>   kioslave/http/http.cpp 70960d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100694/diff
> 
> 
> Testing
> -------
> 
> Tested using the Akonadi Dav groupware resource and DaviCal as a backend server. No issues so far.
> 
> 
> Thanks,
> 
> Grégory
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110220/47171777/attachment.htm>