Review Request: Fix DAV jobs bug

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100694/#review1538
-----------------------------------------------------------

Ship it!


Looks good, but make sure you fix the issue I pointed out below before committing...


kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/100694/#comment1310>

    The size variable here needs to be qint64.


- Dawit


On Feb. 20, 2011, 10:03 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100694/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 10:03 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Following commit 01db8ec6e9934a13ed8025949dab9dd43010bf53 the DAV jobs created with the DavJob::dav* utility functions ceased to work because they do not provide the body data length. This patch corrects this issue by using the same mechanisms as those used for HTTP POST requests.
> 
> 
> Diffs
> -----
> 
>   kio/kio/davjob.cpp 3b2a8da 
>   kioslave/http/http.h e8fe695 
>   kioslave/http/http.cpp 70960d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100694/diff
> 
> 
> Testing
> -------
> 
> Tested using the Akonadi Dav groupware resource and DaviCal as a backend server. No issues so far.
> 
> 
> Thanks,
> 
> Grégory
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110220/1cb109c8/attachment.htm>