Review Request: Fix DAV jobs bug

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100694/#review1535
-----------------------------------------------------------


Except for the inconsistency of using "int" for the size value on the job side and "qint64" in the ioslave side, the patch looks good. If you are sure the data that is going be sent by a DAV job is always going to be less than the overflow limit of an integer, then please change the http ioslave function parameters to int as well. Otherwise, you have to cast the values you send from the job to qint64 and use qint64 everywhere in http ioslave as well.

- Dawit


On Feb. 20, 2011, 8:51 p.m., Grégory Oestreicher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100694/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 8:51 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Following commit 01db8ec6e9934a13ed8025949dab9dd43010bf53 the DAV jobs created with the DavJob::dav* utility functions ceased to work because they do not provide the body data length. This patch corrects this issue by using the same mechanisms as those used for HTTP POST requests.
> 
> 
> Diffs
> -----
> 
>   kio/kio/davjob.cpp 3b2a8da 
>   kioslave/http/http.h e8fe695 
>   kioslave/http/http.cpp 70960d6 
> 
> Diff: http://git.reviewboard.kde.org/r/100694/diff
> 
> 
> Testing
> -------
> 
> Tested using the Akonadi Dav groupware resource and DaviCal as a backend server. No issues so far.
> 
> 
> Thanks,
> 
> Grégory
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110220/73518f30/attachment.htm>