<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100694/">http://git.reviewboard.kde.org/r/100694/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Except for the inconsistency of using "int" for the size value on the job side and "qint64" in the ioslave side, the patch looks good. If you are sure the data that is going be sent by a DAV job is always going to be less than the overflow limit of an integer, then please change the http ioslave function parameters to int as well. Otherwise, you have to cast the values you send from the job to qint64 and use qint64 everywhere in http ioslave as well.</pre>
<br />
<p>- Dawit</p>
<br />
<p>On February 20th, 2011, 8:51 p.m., Grégory Oestreicher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Grégory Oestreicher.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2011, 8:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Following commit 01db8ec6e9934a13ed8025949dab9dd43010bf53 the DAV jobs created with the DavJob::dav* utility functions ceased to work because they do not provide the body data length. This patch corrects this issue by using the same mechanisms as those used for HTTP POST requests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested using the Akonadi Dav groupware resource and DaviCal as a backend server. No issues so far.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/davjob.cpp <span style="color: grey">(3b2a8da)</span></li>
<li>kioslave/http/http.h <span style="color: grey">(e8fe695)</span></li>
<li>kioslave/http/http.cpp <span style="color: grey">(70960d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100694/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>