Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100516/
-----------------------------------------------------------

Review request for kdelibs.


Changes
-------

Did some basic testing of the changes in kio_http using khtml. The repost scenario is still untested after these new changes.


Summary
-------

The attached patch is the first portion a set of patches to make uploading data through HTTP more efficient without affecting the existing implementation. Right now the amount of memory consumed when uploading large files through http or webdav is really not acceptable because only a QByteArray based API is available. That means if you want to upload a file of say 50 or 100 MB to a server, then you have to read the entire thing first before you can call KIO::http_post!


This addresses bug 34578.
    http://bugs.kde.org/show_bug.cgi?id=34578


Diffs
-----

  kio/kio/accessmanager.cpp 722203f 
  kio/kio/global.h 2aa8ebb 
  kio/kio/global.cpp b658d91 
  kio/kio/job.h 632dfc8 
  kio/kio/job.cpp 7d4a849 
  kio/kio/job_p.h daac895 
  kio/kio/jobclasses.h e9bd191 
  kioslave/http/http.h be08d7b 
  kioslave/http/http.cpp 187e3c7 

Diff: http://git.reviewboard.kde.org/r/100516/diff


Testing (updated)
-------

** Used by changing kdewebkit to use the new API. 
** Tested some with khtml to ensure the kio_http changes did not cause any regression.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110211/c49313f3/attachment.htm>