Review Request: Consistent wording between "edit email" and "edit IM" dialogues

Jonathan Marten jjm at keelhaul.me.uk
Wed Feb 2 20:10:22 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100528/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Summary
-------

In the KAddressBook application, there is an inconsistency between the editing dialogues for the email addresses and IM contact addresses.  In the dialogue for email the window title says "... Addresses" and the "set as standard" button says "Set Standard".  In the corresponding dialogue for IM the title says "... Address" (even though there can be more than one) and the same button says "Set as Standard".

This change makes the pluralisation of the window title, and the label of this button, consistent between these two dialogues.


Diffs
-----

  akonadi/contact/editor/emaileditwidget.cpp a931ec1 
  akonadi/contact/editor/im/imeditordialog.cpp 3a2c83f 

Diff: http://git.reviewboard.kde.org/r/100528/diff


Testing
-------

Built kdepimlibs and ran kaddressbook with these changes, verified the display.


Thanks,

Jonathan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110202/1897eb01/attachment.htm>


More information about the kde-core-devel mailing list