Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

Thiago Macieira thiago at kde.org
Thu Feb 10 21:03:48 GMT 2011


On Thursday, 10 de February de 2011 21:08:05 Stephen Kelly wrote:
> Thiago Macieira wrote:
> > It should have been in a qglobalstatic_p.h. We might even do that -- and
> > intentionally break applications that are abusing the API.
> 
> A quick grep says that would break akonadi, grantlee, qca, phonon, qxt and a
> couple of places in KDE that use it already (presumably they don't need the
> features of K_GLOBAL_STATIC that you mentioned). If you (re)move it, we'd
> all just end up copying the macro into our own codebases, so that wouldn't
> achieve much.

Phonon should have a copy of K_GLOBAL_STATIC.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110210/6789e3c5/attachment.sig>


More information about the kde-core-devel mailing list