Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100516/#review1305
-----------------------------------------------------------

Ship it!


Looks good, but...


kio/kio/job.cpp
<http://git.reviewboard.kde.org/r/100516/#comment1086>

    Shouldn't there be a kio_http patch to go along with this? Otherwise the post data size is not used. Or was that just "for the future"?


- David


On Feb. 7, 2011, 6:46 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100516/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2011, 6:46 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The attached patch is the first portion a set of patches to make uploading data through HTTP more efficient without affecting the existing implementation. Right now the amount of memory consumed when uploading large files through http or webdav is really not acceptable because only a QByteArray based API is available. That means if you want to upload a file of say 50 or 100 MB to a server, then you have to read the entire thing first before you can call KIO::http_post!
> 
> 
> This addresses bug 34578.
>     http://bugs.kde.org/show_bug.cgi?id=34578
> 
> 
> Diffs
> -----
> 
>   kio/kio/job.h 632dfc8 
>   kio/kio/job.cpp 7d4a849 
>   kio/kio/job_p.h daac895 
>   kio/kio/jobclasses.h e9bd191 
> 
> Diff: http://git.reviewboard.kde.org/r/100516/diff
> 
> 
> Testing
> -------
> 
> Used by changing kdewebkit to use the new API. 
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110208/1391daa2/attachment.htm>