Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100516/
-----------------------------------------------------------

(Updated Feb. 7, 2011, 6:46 p.m.)


Review request for kdelibs.


Changes
-------

* Added size parameter to the new POST APIs based on discussion.
* Changed both the new and old POST APIs to always send content size information to the ioslaves.


Summary
-------

The attached patch is the first portion a set of patches to make uploading data through HTTP more efficient without affecting the existing implementation. Right now the amount of memory consumed when uploading large files through http or webdav is really not acceptable because only a QByteArray based API is available. That means if you want to upload a file of say 50 or 100 MB to a server, then you have to read the entire thing first before you can call KIO::http_post!


This addresses bug 34578.
    http://bugs.kde.org/show_bug.cgi?id=34578


Diffs (updated)
-----

  kio/kio/job.h 632dfc8 
  kio/kio/job.cpp 7d4a849 
  kio/kio/job_p.h daac895 
  kio/kio/jobclasses.h e9bd191 

Diff: http://git.reviewboard.kde.org/r/100516/diff


Testing
-------

Used by changing kdewebkit to use the new API. 


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110207/61114016/attachment.htm>