Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

[Dawit Alemayehu]

> On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote:
> > Please also add the { } around single line blocks (as per kdelibs coding style).
> 
> Dawit Alemayehu wrote:
>     Lets us forget about such nitpicks, okay... If such unnecessary coding styles were to be enforced, there would be so many lines of code that would need fixing in this very same file.
> 
> Pino Toscano wrote:
>     Well, is writing new code correctly so hard? I'm not asking you to fix all the other "issues", but to just write the new code correctly.

It is when I have to unnecessarily type more than I have to. Seriously this is getting to be annoying and I do not mean you personally. These rigid and brittle coding styles. One project says no braces for single line statements and another says the complete opposite. I have no problem with some common sense coding style rules, but please spare me from such nonsense micro management of each and every line of code, specially since the people working on kdelibs should in the least be well versed about the pitfalls of using or not using braces, even for single line statements.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100539/#review1190
-----------------------------------------------------------


On Feb. 4, 2011, 10:11 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100539/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 10:11 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached patch is a workaround to the much discussed issue with VLC hanging when opening a KDE file dialog. For the details about the causes of this bug, see http://lists.kde.org/?t=129572447500001&r=1&w=2 and the bug report linked above...
> 
> 
> This addresses bug 260719.
>     http://bugs.kde.org/show_bug.cgi?id=260719
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kmimetyperepository.cpp 9f4c3ca 
> 
> Diff: http://git.reviewboard.kde.org/r/100539/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/c2586eec/attachment.htm>