Review Request: Reset time format upon user request
Lamarque V. Souza
lamarque at kde.org
Sun Dec 18 22:26:42 GMT 2011
Em Sunday 18 December 2011, David Faure escreveu:
> On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote:
> > Another problem with this approach is that we cannot prevent anybody else
> > from listening to
> > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged,
> > KGlobalSettings::SETTING_LOCALE).
> What would be wrong with that? It would be the way to have a GUI that
> reacts to changes in the locale settings. Every app and in particular
> date/time widgets might want to listen to that and adapt.
> Or did I misunderstand what this was about?
You misunderstood what I meant. You removed that paragraph from the
context of the first paragraph of my last e-mail. What I meant is that if we
use something like KLocale::commit() then we should not let others use
KGlobalSettings::SETTING_LOCALE). If we just add
KGlobalSettings::SETTING_LOCALE to kglobalsettings.h then it is correct that
everybody uses it.
The problem with KGlobalSettings::SETTING_LOCALE is that is solves only
half the problem. I am using a hack to force the local KLocale instance in the
clock plasmoid to reload the configuration files. There is no API in kdelibs
to reload KLocale's configuration files and that is why I suggested using
something like KLocale::commit() when Aaron complained about my second review
of this patch.
> > I am trying to minimize the number of patches needed to fix bug #289094.
> If everyone only went for the "minimal lines of code" fix all the time, we
> would have one hell of a mess by now...
I am not familiar with this part of kdelibs and it is very clear it is a
very sensible part of kdelibs. Anything wrong here will be noticed by
everybody, that is why I am trying to do the minimum in this case.
Lamarque V. Souza
KDE's Network Management maintainer
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-core-devel