Review Request: Add 1em right padding to info pages generated by kio_info

[Dawit Alemayehu]

> On Dec. 16, 2011, 10:50 a.m., Thomas Lübking wrote:
> > please use "20pt" or "1em" - even todays notebooks often have >=150dpi and you can expect this value to rise (macbook rumors...)
> 
> Thomas Lübking wrote:
>     errr... soryr for this probably stupid question, but why isn't the kde-defaults.css "fixed" then?
>     (just compared info:/ to man:/  - looks like blog.fefe.de where apparently everyone is supposed to use his own stylesheet ;-)
>     
>     In other words and looking at the common header of man:/ and info:/ and for the fact that .chapter is handled there as well:
>     I guess the info:/ definition in kde-defaults.css is just not complete and i guess we should have a general central "corporate" design to align those looks, yesno?

Because the content generated by each of the generators for those protocols has its own quirks and chaging the right padding inside a commonly shared CSS file like kde-default.css might inadvertantly break something else that uses it ?? For example, the man protocol most definitely does not this change and adding an additional 1em right padding would unnecessarily squish its content further right. Since the generated man pages are already formatted properly this change will most definitely have adverse effect on one of the many pages. The same applies to all the other places kde-default.css is used.

As far as I am concerned this issue is very specific to the kde-info2html generator and as such the fix applies to it alone. At least until someone has the time to throughly determine such change can safely be moved to a common location like kde-default.css.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103426/#review8994
-----------------------------------------------------------


On Dec. 16, 2011, 2:15 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103426/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 2:15 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> The patch adds a 20 px margin to info pages generated by kio_info to make them easier to read.
> 
> 
> This addresses bug 230959.
>     http://bugs.kde.org/show_bug.cgi?id=230959
> 
> 
> Diffs
> -----
> 
>   kioslave/info/kde-info2html 03ace75 
> 
> Diff: http://git.reviewboard.kde.org/r/103426/diff/diff
> 
> 
> Testing
> -------
> 
> Tested by displaying info:/make/Goals.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111216/f7e26c60/attachment.htm>