Review Request: Add git support to kdesdk: create_tarball.rb

Albert Astals Cid aacid at kde.org
Sat Dec 3 14:52:24 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6842/#review10511
-----------------------------------------------------------

Ship it!


The changes seem very minor, and from what i can see they will not "break" the svn support, so just go for it if it works for you. 

We can fix any new issues in git support as they arise.

- Albert Astals Cid


On Nov. 29, 2011, 4:42 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6842/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2011, 4:42 p.m.)
> 
> 
> Review request for kdelibs and Release Team.
> 
> 
> Description
> -------
> 
> This patch adds git support to create_tarball.rb in kdesdk. The patch adds two options to the ini file. The first one (gitModule) indicates that the module is located in git and the second optional parameter (gitTag) defines which tag to use for creating the release. (there is no group for kdesdk or extragear)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277 
>   trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277 
> 
> Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111203/5ee52851/attachment.htm>


More information about the kde-core-devel mailing list