Review Request: Add git support to kdesdk: create_tarball.rb

[Thomas Baumgart]

> On Nov. 30, 2011, 6:01 p.m., Thomas Baumgart wrote:
> > trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb, line 443
> > <http://svn.reviewboard.kde.org/r/6842/diff/1/?file=47267#file47267line443>
> >
> >     Is there a specific reason why you don't add the doc subdirectory for stuff fetched from git?
> 
> Kåre Särs wrote:
>     The git modules I have checked, have the non-translated documents in the git repo and the directory already added in the CMakeLists.txt. I take it that, that is the "standard" :) So the documentation should actually be built.

Apologies, you're right. KMyMoney is the culprit. We just did not update to the newer layout since we came into git from svn.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6842/#review10493
-----------------------------------------------------------


On Nov. 29, 2011, 4:42 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6842/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2011, 4:42 p.m.)
> 
> 
> Review request for kdelibs and Release Team.
> 
> 
> Description
> -------
> 
> This patch adds git support to create_tarball.rb in kdesdk. The patch adds two options to the ini file. The first one (gitModule) indicates that the module is located in git and the second optional parameter (gitTag) defines which tag to use for creating the release. (there is no group for kdesdk or extragear)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277 
>   trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277 
> 
> Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111202/ab1a1f5e/attachment.htm>