Review Request: accept KAssitantDialog when calling next() on last page and if that is valid

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102475/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The apidox for KAssitantDialog::next says:

        /**
         * Called when the user clicks the Next/Finish button.
         *
         * This function will show the next relevant page in the sequence.
         * If the current page is the last page, it will call accept()
         */

The last sentence is actually not true and this patch introduces this behavior.


Diffs
-----

  kdeui/dialogs/kassistantdialog.cpp 0cb361a 

Diff: http://git.reviewboard.kde.org/r/102475/diff


Testing
-------

You can add this before the "return a.exec();" in kassistantdialogtest.cpp to verify that it now works as intended:

  for(int i = 1; i < 11; i++)
  {
	QMetaObject::invokeMethod(dlg, "next", Qt::QueuedConnection);
  }
  


Thanks,

Milian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110828/2bdb9d75/attachment.htm>