Review Request: accept KAssitantDialog when calling next() on last page and if that is valid

Milian Wolff mail at
Sun Aug 28 13:51:57 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


The apidox for KAssitantDialog::next says:

         * Called when the user clicks the Next/Finish button.
         * This function will show the next relevant page in the sequence.
         * If the current page is the last page, it will call accept()

The last sentence is actually not true and this patch introduces this behavior.


  kdeui/dialogs/kassistantdialog.cpp 0cb361a 



You can add this before the "return a.exec();" in kassistantdialogtest.cpp to verify that it now works as intended:

  for(int i = 1; i < 11; i++)
	QMetaObject::invokeMethod(dlg, "next", Qt::QueuedConnection);



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list