Review Request: Find list items by typing their initial letters.

[Peter Penz]

> On Aug. 27, 2011, 9:08 p.m., Peter Penz wrote:
> > Thanks for this patch. As discussed per e-mail already I think from a design point of view this is fine and the patch looks good! I've added quite a lot of nitpicking comments, would be great if you could fix those things and do one update here. Afterwards I'm confident that this can be pushed.

Ah, forgot regarding the coding style nitpicks - Dolphin tries to follow the coding-style in kdelibs: http://techbase.kde.org/Policies/Kdelibs_Coding_Style


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102465/#review6075
-----------------------------------------------------------


On Aug. 27, 2011, 8:36 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102465/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2011, 8:36 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in.
> 
> p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work.
> p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 31d3f89 
>   dolphin/src/kitemviews/kfileitemmodel.h 654c7db 
>   dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 
>   dolphin/src/kitemviews/kitemlistcontroller.h 134e116 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 
>   dolphin/src/kitemviews/kitemlistkeyboardmanager.h PRE-CREATION 
>   dolphin/src/kitemviews/kitemlistkeyboardmanager.cpp PRE-CREATION 
>   dolphin/src/kitemviews/kitemmodelbase.h 4670469 
>   dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 
> 
> Diff: http://git.reviewboard.kde.org/r/102465/diff
> 
> 
> Testing
> -------
> 
> yes. tested and works.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110827/46010401/attachment.htm>