Review Request: Find list items by typing their initial letters.

Tirtha Chatterjee tirtha.p.chatterjee at
Sat Aug 27 21:36:19 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 27, 2011, 8:36 p.m.)

Review request for KDE Base Apps and Peter Penz.


Changed the name of the macro for the header of KItemListKeyboardManager class.

However, It is to be noted that if we do introduce a tranlucent lineedit to show what has been typed, like GTK+ does, the code of the KItemListKeyboardManager would be best put into that class. Because then, we do not need to trap all keyPressEvents, just show the lineedit on the first keyPressEvent which isn't a direction key, then connect textChanged to a timer, and also to KItemListController::slotKeyboardActivationRequested. I think all applications which use this itemview framework can use it (or optionally turn it off). Do we need to worry about breaking API in this case?


This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in.

p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work.
p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big.

Diffs (updated)

  dolphin/src/CMakeLists.txt 31d3f89 
  dolphin/src/kitemviews/kfileitemmodel.h 654c7db 
  dolphin/src/kitemviews/kfileitemmodel.cpp f36ab83 
  dolphin/src/kitemviews/kitemlistcontroller.h 134e116 
  dolphin/src/kitemviews/kitemlistcontroller.cpp 2e32880 
  dolphin/src/kitemviews/kitemlistkeyboardmanager.h PRE-CREATION 
  dolphin/src/kitemviews/kitemlistkeyboardmanager.cpp PRE-CREATION 
  dolphin/src/kitemviews/kitemmodelbase.h 4670469 
  dolphin/src/kitemviews/kitemmodelbase.cpp fc604e7 



yes. tested and works.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list