<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102465/">http://git.reviewboard.kde.org/r/102465/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps and Peter Penz.</div>
<div>By Tirtha Chatterjee.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2011, 8:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed the name of the macro for the header of KItemListKeyboardManager class.
However, It is to be noted that if we do introduce a tranlucent lineedit to show what has been typed, like GTK+ does, the code of the KItemListKeyboardManager would be best put into that class. Because then, we do not need to trap all keyPressEvents, just show the lineedit on the first keyPressEvent which isn't a direction key, then connect textChanged to a timer, and also to KItemListController::slotKeyboardActivationRequested. I think all applications which use this itemview framework can use it (or optionally turn it off). Do we need to worry about breaking API in this case?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows finding items by typing on the keyboard while the KItemListController is in focus. Timer and key queuing is handled by KItemListKeyboardManager, and search itself is done by reimplementing indexForKeyboardSearch(QString) from KItemModelBase. This implementation does not, at the moment, take care of the repetitive typing as suggested by Frank. I think we can implement that once this is in.
p.s. Not sure if line 213 in kitemlistcontroller.cpp is the best way to do it. Returning true does not work.
p.s. I feel the name KItemListKeyboardManager can be changed to KItemListKeyboardSearchManager, although a little too big.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes. tested and works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(31d3f89)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.h <span style="color: grey">(654c7db)</span></li>
<li>dolphin/src/kitemviews/kfileitemmodel.cpp <span style="color: grey">(f36ab83)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.h <span style="color: grey">(134e116)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: grey">(2e32880)</span></li>
<li>dolphin/src/kitemviews/kitemlistkeyboardmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/kitemlistkeyboardmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/kitemmodelbase.h <span style="color: grey">(4670469)</span></li>
<li>dolphin/src/kitemviews/kitemmodelbase.cpp <span style="color: grey">(fc604e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>