Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102419/#review5984
-----------------------------------------------------------

Ship it!


Sure, but finding where the null pointer comes from (in konqueror's code apparently) would be a good idea too :-)

- David


On Aug. 24, 2011, 5:27 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102419/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2011, 5:27 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> This patch addresses the crash outlined in bug# 265217. Though a null QAction should not be present in the parameter passed to XMLGUIFactoryPrivate::saveDefaultActionProperties in the first place, the code in that function should be reiliant enough not to crash even such a QAction exists.
> 
> 
> This addresses bug 265217.
>     http://bugs.kde.org/show_bug.cgi?id=265217
> 
> 
> Diffs
> -----
> 
>   kdeui/xmlgui/kxmlguifactory.cpp 4e6989b 
> 
> Diff: http://git.reviewboard.kde.org/r/102419/diff
> 
> 
> Testing
> -------
> 
> Checked to make sure the crash no longer happens with this patch applied.
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110824/22145546/attachment.htm>