Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

Dawit Alemayehu adawit at
Wed Aug 24 06:27:53 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and David Faure.


This patch addresses the crash outlined in bug# 265217. Though a null QAction should not be present in the parameter passed to XMLGUIFactoryPrivate::saveDefaultActionProperties in the first place, the code in that function should be reiliant enough not to crash even such a QAction exists.

This addresses bug 265217.


  kdeui/xmlgui/kxmlguifactory.cpp 4e6989b 



Checked to make sure the crash no longer happens with this patch applied.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list