Review Request: GSoC: Errors handling during file transfer.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review5944
-----------------------------------------------------------



kio/kio/copyjob.cpp
<http://git.reviewboard.kde.org/r/102388/#comment5253>

    Remove, unused now.



kio/kio/copyjob.cpp
<http://git.reviewboard.kde.org/r/102388/#comment5254>

    Maybe the property name should be less generic, to avoid possible clashes (e.g. with Qt or KJob future changes).
    I would suggest "interactionId" (make sure to change it everywhere ... which is a good reason for using a
     static const char s_interactionIdProperty[] = "interactionId";
    )


- David


On Aug. 22, 2011, 11:12 p.m., Cyril Oblikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102388/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2011, 11:12 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Modeless dialog to handle interactions and modifications in CopyJob.
> 
> 
> Diffs
> -----
> 
>   kio/CMakeLists.txt b517621 
>   kio/kio/copyjob.h eb88c7a 
>   kio/kio/copyjob.cpp eff7825 
>   kio/kio/interactiondialog/abstractinteractionitem_p.h PRE-CREATION 
>   kio/kio/interactiondialog/abstractinteractionmodel.cpp PRE-CREATION 
>   kio/kio/interactiondialog/abstractinteractionmodel_p.h PRE-CREATION 
>   kio/kio/interactiondialog/allinteractionitem.cpp PRE-CREATION 
>   kio/kio/interactiondialog/allinteractionitem_p.h PRE-CREATION 
>   kio/kio/interactiondialog/allinteractionmodel.cpp PRE-CREATION 
>   kio/kio/interactiondialog/allinteractionmodel_p.h PRE-CREATION 
>   kio/kio/interactiondialog/existinginteractionitem.cpp PRE-CREATION 
>   kio/kio/interactiondialog/existinginteractionitem_p.h PRE-CREATION 
>   kio/kio/interactiondialog/existinginteractionmodel.cpp PRE-CREATION 
>   kio/kio/interactiondialog/existinginteractionmodel_p.h PRE-CREATION 
>   kio/kio/interactiondialog/interactiondialog.h PRE-CREATION 
>   kio/kio/interactiondialog/interactiondialog.cpp PRE-CREATION 
>   kio/kio/interactiondialog/interactiondialogtab.cpp PRE-CREATION 
>   kio/kio/interactiondialog/interactiondialogtab_p.h PRE-CREATION 
>   kio/kio/interactiondialog/renameinteractionwidget.h PRE-CREATION 
>   kio/kio/interactiondialog/renameinteractionwidget.cpp PRE-CREATION 
>   kio/kio/interactiondialog/requestitemmodel.cpp PRE-CREATION 
>   kio/kio/interactiondialog/requestitemmodel_p.h PRE-CREATION 
>   kio/kio/interactiondialog/unreadableinteractionitem.cpp PRE-CREATION 
>   kio/kio/interactiondialog/unreadableinteractionitem_p.h PRE-CREATION 
>   kio/kio/interactiondialog/unreadableinteractionmodel.cpp PRE-CREATION 
>   kio/kio/interactiondialog/unreadableinteractionmodel_p.h PRE-CREATION 
>   kio/kio/jobuidelegate.h 25e0728 
>   kio/kio/jobuidelegate.cpp 85679c2 
> 
> Diff: http://git.reviewboard.kde.org/r/102388/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cyril
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110823/ea67971e/attachment.htm>