<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102388/">http://git.reviewboard.kde.org/r/102388/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102388/diff/3/?file=32571#file32571line174" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/copyjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">172</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSignalMapper</span> <span class="n">m_signalMapper</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove, unused now.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102388/diff/3/?file=32571#file32571line598" style="color: black; font-weight: bold; text-decoration: underline;">kio/kio/copyjob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CopyJobPrivate::slotExistingFile(KJob *job)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">595</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QVariant</span> <span class="n">property</span> <span class="o">=</span> <span class="n">job</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"id"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe the property name should be less generic, to avoid possible clashes (e.g. with Qt or KJob future changes).
I would suggest "interactionId" (make sure to change it everywhere ... which is a good reason for using a
static const char s_interactionIdProperty[] = "interactionId";
)</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 22nd, 2011, 11:12 p.m., Cyril Oblikov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Cyril Oblikov.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2011, 11:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modeless dialog to handle interactions and modifications in CopyJob.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(b517621)</span></li>
<li>kio/kio/copyjob.h <span style="color: grey">(eb88c7a)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(eff7825)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionitem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionitem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionitem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialogtab.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialogtab_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/renameinteractionwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/renameinteractionwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/requestitemmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/requestitemmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionitem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionmodel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kio/kio/jobuidelegate.h <span style="color: grey">(25e0728)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102388/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>