Review Request: Speed limit in ftp kio slave

Tushar Mehta mehtatus at gmail.com
Tue Aug 9 20:16:08 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102267/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

- This patch contains the basic code which will put the limit on download speed of the ftp data transfer.
- It is looking for "speed-limit" meta-data for deciding how much speed control is required.
- If this meta-data is not found, code will work as it was before and no speed control related code will come into picture.
- This patch is the most basic one which I have testing on my system and to the extent it is controlling the speed.
- Lets say if speed limit is 30 KBps then mostly will get the avg speed around 30 to 35 KBps.
- I am using QTime for measuring time elapsed between two socket read call and its precision is in millisecond. Looping is taking place in microsecond and thats why I am getting almost all the time 0 as time elapsed in between two calls.
- To solve the above problem usleep is introduced to make it sync with the timer.


Diffs
-----

  kioslave/ftp/CMakeLists.txt e080b02 
  kioslave/ftp/ftp.h 0bd375b 
  kioslave/ftp/ftp.cpp 655524a 
  kioslave/ftp/speedController.h PRE-CREATION 
  kioslave/ftp/speedController.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102267/diff


Testing
-------


Thanks,

Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110809/4da279f9/attachment.htm>


More information about the kde-core-devel mailing list