<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102267/">http://git.reviewboard.kde.org/r/102267/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Tushar Mehta.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- This patch contains the basic code which will put the limit on download speed of the ftp data transfer.
- It is looking for "speed-limit" meta-data for deciding how much speed control is required.
- If this meta-data is not found, code will work as it was before and no speed control related code will come into picture.
- This patch is the most basic one which I have testing on my system and to the extent it is controlling the speed.
- Lets say if speed limit is 30 KBps then mostly will get the avg speed around 30 to 35 KBps.
- I am using QTime for measuring time elapsed between two socket read call and its precision is in millisecond. Looping is taking place in microsecond and thats why I am getting almost all the time 0 as time elapsed in between two calls.
- To solve the above problem usleep is introduced to make it sync with the timer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/CMakeLists.txt <span style="color: grey">(e080b02)</span></li>
<li>kioslave/ftp/ftp.h <span style="color: grey">(0bd375b)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(655524a)</span></li>
<li>kioslave/ftp/speedController.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kioslave/ftp/speedController.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102267/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>