Review Request: Using KWallet to store Cookies

[Dawit A]

Would you be able to create a new request in git.reviewboard.kde.org for
this so that it won't fall through the cracks ? Perhaps there is still a
chance for this making the KDE 4.7 release. The only reservation I have is
the ability to unit test things when cookies are stored in the kwallet. Have
you been able to run the extensive kcookiejar unit tests under such a setup
?

Also you would need to split the GUI configuration from the non-gui portion
if you plan to resubmit into the new reviewboard. Anyhow, I would be willing
to give it a try and review it again if you are inclined to do so...

2011/1/21 José Millán Soto <fid at gpul.org>

>    This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4927/
>   Review request for kdelibs.
> By José Millán Soto.
>
> *Updated Jan. 21, 2011, 5:37 p.m.*
> Changes
>
> New version of the patch.
> Instead of using QEventLoop, delayed DBus messages are used.
>
>   Description
>
> Currently cookies are stored in a plain text file. This patch allows KCookieJar to store the cookies securely using KWallet.
>
> The main problem I had writing this patch was that when a web page is requested, KIO ask for the cookies to kded using dbus. In the first implementations that I wrote, if the user took too long to open the wallet, KIO received a dbus timeout.
>
> To prevent this, if it takes more than 10 seconds to open the wallet, the web page will be requested without sending the cookies (or sending the available cookies if there's still the plain text cookie file). If the wallet is opened after that, the cookies stored in the wallet will be available since then.
>
> Because of this, the feature is disabled by default.
>
>   Diffs (updated)
>
>    - /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.cpp
>    (1215885)
>    - /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespoliciesdlg.ui
>    (1215885)
>    - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.h (1215938)
>    - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookiejar.cpp (1215938)
>    - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.h (1215938)
>    - /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp
>    (1215938)
>
> View Diff <http://svn.reviewboard.kde.org/r/4927/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110419/6ebc32e8/attachment.htm>