Review Request: GUI configuration for the 'Do Not Track' feature...

[Dawit A]

On Thu, Apr 14, 2011 at 6:26 PM, Maksim Orlovich <mo85 at cornell.edu> wrote:
> Ah, I misread the default. But still, I don't think we want to send
> DNT:0 if the user unchecks the checkbox, given how the label is worded
> -- IMHO we wouldn't want to send the header at all.

That makes no sense especially since not sending the header is
currently equivalent to DNT: 1. The configuration option is there to
allow the user to opt-in if they so choose. Otherwise, it makes no
sense to have the configuration option in the first place. Anyhow, I
copied the wording verbatim from Firefox 4.0 configuration dialog and
as such can be changed to whatever we want. Perhaps I should have
labeled it like most other KDE option:

[  ]  Allow websites I visit to track my browsing habits


>
> On 4/14/11, Dawit Alemayehu <adawit at kde.org> wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/101124/
>> -----------------------------------------------------------
>>
>> (Updated April 14, 2011, 5:08 p.m.)
>>
>>
>> Review request for kdelibs.
>>
>>
>> Changes
>> -------
>>
>> Based on Maksim's feedback, updated comment in the code to correctly reflect
>> what the code is actually doing.
>>
>>
>> Summary
>> -------
>>
>> The attach patch adds GUI configuration for the 'Do Not Track' feature that
>> has just been implemented in kio_http[1]. Support for the Do Not Track
>> functionality exists in almost all of the recent versions of the major
>> browsers. The draft spec for this feature can be found at
>> http://www.ietf.org/id/draft-mayer-do-not-track-00.txt.
>>
>> [1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f558837553
>>
>> Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any
>> objections, insights, suggestions are all welcome before I commit this.
>>
>>
>> Diffs (updated)
>> -----
>>
>>   konqueror/settings/konqhtml/htmlopts.h b0faf0d
>>   konqueror/settings/konqhtml/htmlopts.cpp 1ca17cb
>>
>> Diff: http://git.reviewboard.kde.org/r/101124/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Dawit
>>
>>
>