Review Request: GUI configuration for the 'Do Not Track' feature...

[Maksim Orlovich]

Ah, I misread the default. But still, I don't think we want to send
DNT:0 if the user unchecks the checkbox, given how the label is worded
-- IMHO we wouldn't want to send the header at all.


On 4/14/11, Dawit Alemayehu <adawit at kde.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101124/
> -----------------------------------------------------------
>
> (Updated April 14, 2011, 5:08 p.m.)
>
>
> Review request for kdelibs.
>
>
> Changes
> -------
>
> Based on Maksim's feedback, updated comment in the code to correctly reflect
> what the code is actually doing.
>
>
> Summary
> -------
>
> The attach patch adds GUI configuration for the 'Do Not Track' feature that
> has just been implemented in kio_http[1]. Support for the Do Not Track
> functionality exists in almost all of the recent versions of the major
> browsers. The draft spec for this feature can be found at
> http://www.ietf.org/id/draft-mayer-do-not-track-00.txt.
>
> [1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f558837553
>
> Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any
> objections, insights, suggestions are all welcome before I commit this.
>
>
> Diffs (updated)
> -----
>
>   konqueror/settings/konqhtml/htmlopts.h b0faf0d
>   konqueror/settings/konqhtml/htmlopts.cpp 1ca17cb
>
> Diff: http://git.reviewboard.kde.org/r/101124/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit
>
>