Review Request: GUI configuration for the 'Do Not Track' feature...

[Maksim Orlovich]

Very cool. But re: original change. Are you sure we want to be sending
the opt-in header by default? (Also, does KProtocolManager copy
kioslaverc into the metadata or something, or will that need a
separate change?).  Can't really review this right now, but one thing
that I noticed:
// Read the configuration from konquerorrc
might be clearer to add "with khtmlrc as fallback" to the comment.






On 4/14/11, Dawit Alemayehu <adawit at kde.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101124/
> -----------------------------------------------------------
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> The attach patch adds GUI configuration for the 'Do Not Track' feature that
> has just been implemented in kio_http[1]. Support for the Do Not Track
> functionality exists in almost all of the recent versions of the major
> browsers. The draft spec for this feature can be found at
> http://www.ietf.org/id/draft-mayer-do-not-track-00.txt.
>
> [1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f558837553
>
> Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any
> objections, insights, suggestions are all welcome before I commit this.
>
>
> Diffs
> -----
>
>   konqueror/settings/konqhtml/htmlopts.h b0faf0d
>   konqueror/settings/konqhtml/htmlopts.cpp 1ca17cb
>
> Diff: http://git.reviewboard.kde.org/r/101124/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit
>
>