Review Request: fix broken nepomuk ui files to make messages translatable

Sebastian Trueg sebastian at trueg.de
Thu Apr 14 08:34:44 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101112/#review2626
-----------------------------------------------------------

Ship it!


Looks fine to me. I simply used the designer field that said "comment". But I just checked - it might be that the german translation of Designer is a bit weird: "Kennung" seems to be the one to use instead of "Kommentar".

- Sebastian


On April 13, 2011, 2:04 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101112/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 2:04 p.m.)
> 
> 
> Review request for KDE Runtime and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Some nepomuk ui files have strings like <string extracomment="@info">some message</string>
> xgettext extracts this properly to msgctxt "@info" msgid "some message"
> ui compiler generates tr2i18n("some message", 0) -> that does not match xgettext, therefore no translated msg is found
> 
> With <string comment="@info">some message</string>
> the ui compiler generates tr2i18n("some message", "@info"), that does match xgettext and the translated msg is found and shown
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/nepomukconfigwidget.ui 5652274 
>   nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 
>   nepomuk/services/backupsync/gui/intropage.ui 1a74630 
>   nepomuk/services/backupsync/gui/restoreselection.ui 157c50a 
> 
> Diff: http://git.reviewboard.kde.org/r/101112/diff
> 
> 
> Testing
> -------
> 
> Tested using locale x-test (http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module), 
> messages are translated
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110414/4ec909a7/attachment.htm>


More information about the kde-core-devel mailing list