Review Request: Add missing KAuthorize "hooks" on KFileItemActions

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101082/#review2598
-----------------------------------------------------------

Ship it!


looks good; other code using this might Do The Right Thing(tm) as well, but it's good to centralize these checks.

- Aaron J.


On April 11, 2011, 12:22 p.m., Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101082/
> -----------------------------------------------------------
> 
> (Updated April 11, 2011, 12:22 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> I found 2 places where KAuthorize should be added:
> KFileItemActions::addOpenWithActionsTo(QMenu* topMenu, const QString& traderConstraint)
> 
> In this method as you can see, the first option is a QMenu pointer where the new "open with" actions will be added. If we don't check in this function if "openwith" is allowed we will end up having "Open with" action (or having to patch all apps :p)
> 
> The second place is: 
> KFileItemActionsPrivate::slotExecuteService(QAction* act)
> 
> This is where the actual action is executed, just for """""security""""" and robustness we should check here too.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kfileitemactions.cpp 7f7d5c9 
> 
> Diff: http://git.reviewboard.kde.org/r/101082/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110412/5338fcca/attachment.htm>