Review Request: Fix directory navigation in Dolphin::Terminal.

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101096/#review2571
-----------------------------------------------------------

Ship it!


Thanks, looks good!


dolphin/src/panels/terminal/terminalpanel.cpp
<http://git.reviewboard.kde.org/r/101096/#comment2249>

    Please leave the open/closing braces also when only one statement is used (see http://techbase.kde.org/Policies/Kdelibs_Coding_Style)


- Peter


On April 12, 2011, 4:37 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101096/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 4:37 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Fix directory navigation in Dolphin::Terminal.
> 
> When navigating in Dolphin it attempts to keep any open Terminal (F4)
> in sync by changing the directory in the shell.  It does this by
> sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C"
> as a literal string and not SIGINT.  Fix this by sending SIGINT to the
> shell instead of "^C".
> 
> It appears Linux does not exhibit this behaviour.
> 
> Patch originally written by David Naylor, from the KDE-FreeBSD team.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/terminal/terminalpanel.cpp 61d80cbfa26fb17d0ba403a52f2ab57fbae7b3cc 
> 
> Diff: http://git.reviewboard.kde.org/r/101096/diff
> 
> 
> Testing
> -------
> 
> Changing directories with a terminal open now changes the terminal's current directory fine on FreeBSD.
> 
> 
> Thanks,
> 
> Raphael
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110412/d76d7070/attachment.htm>